allow temperatures to work when the display name is changed #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olbrich
added a commit
that referenced
this pull request
May 26, 2012
allow temperatures to work when the display name is changed
|
Good catch, thanks! |
olbrich
added a commit
that referenced
this pull request
May 27, 2012
…after themselves * remove all hard coded temperature handling from unit.rb * generate regexes required to detect temperatures and degrees * push temperature conversion routines into procs on the Unit definition. This makes it possible to introduce arbitrary (and non-linear) temperature scales.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes so that temperature units are still handled correctly when their display names are changed